Opened 3 years ago

Last modified 9 months ago

#4621 new defect

EcheLoN doesn't broadcast rating after a rated 1v1

Reported by: elexis Owned by:
Priority: Should Have Milestone: Backlog
Component: Multiplayer lobby Keywords:
Cc: Patch:

Description

After having finished a rated 1v1 and returning to the lobby, the rating of the current player is still the old one cached somewhere.

So if the player joins a game with that outdated rating, then crashes / disconnects / restarts the game and joins the lobby again, the new rating will be loaded and thus the player won't get it's assigned playerID again.

We should really remove the rating from the nick.

Change History (5)

comment:1 by elexis, 3 years ago

(This also occurs for the current a21 bot and fixes itself after some time (next player lobby join?).)

comment:2 by elexis, 3 years ago

Milestone: BacklogWork In Progress

It's because both bots have Phab:D206 applied with a bug noticed by user1: https://code.wildfiregames.com/D206#inline-7802

comment:3 by elexis, 3 years ago

Presumed by scythetwirler that was.

The rating bots both have that typo fixed and were restarted, but the bug persists.

comment:4 by elexis, 22 months ago

Milestone: Work In ProgressBacklog

comment:5 by elexis, 9 months ago

Summary: Rating not reloaded when returning to the lobby after a rated 1v1EcheLoN doesn't broadcast rating after a rated 1v1

The root cause for the error seems to be that EcheLOn.py only sends the ratinglist update after the gamereport only to one of the players, but every participant in the muc room needs to know the update in fact.

The "cant rejoin due to outdated cached rating" issue had been addressed in r19828 / #3686.

Note: See TracTickets for help on using tickets.