Opened 7 years ago
Last modified 3 years ago
#4636 new defect
Territory Manager should exclude 3 territory tile border
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Backlog |
Component: | Simulation | Keywords: | simple |
Cc: | Patch: |
Description (last modified by )
In CCmpRangeManager.cpp
we have
// WARNING: CCmpPathfinder::UpdateGrid needs to be kept in sync with this const ssize_t edgeSize = 3; // number of vertexes around the edge that will be off-world
In CCmpPathfinder.cpp
we have
// Compute off-world passability // WARNING: CCmpRangeManager::LosIsOffWorld needs to be kept in sync with this const int edgeSize = 3 * Pathfinding::NAVCELLS_PER_TILE; // number of tiles around the edge that will be off-world
This ticket can be solved in two separate patches:
1) The magic number should become a global constant.
2) The number must be taken into account in CCmpTerritoryManager.cpp
as well, so that the territory line doesn't disappear in the shroud of darkness.
(This might influence #4267)
Attachments (2)
Change History (11)
by , 7 years ago
Attachment: | hidden_territory_at_map_border.jpg added |
---|
comment:1 by , 7 years ago
Description: | modified (diff) |
---|
comment:2 by , 6 years ago
comment:3 by , 5 years ago
Component: | UI & Simulation → Simulation |
---|
Move tickets to Simulation
as UI & Simulation
got some sub components.
by , 5 years ago
Attachment: | screenshot0540.jpg added |
---|
comment:4 by , 5 years ago
Keywords: | pathfinding removed |
---|
As mentioned by wraitii, the constant was introduced in r8882.
The reason for the constant and why it is precisely 3 becomes clear when looking at edgetiles = 0:
comment:7 by , 3 years ago
Description: | modified (diff) |
---|
comment:8 by , 3 years ago
Keywords: | simple removed |
---|---|
severity: | → simple |
comment:9 by , 3 years ago
Keywords: | simple added |
---|
Note:
See TracTickets
for help on using tickets.
In 20283: