Opened 7 years ago

Closed 7 years ago

#4647 closed defect (fixed)

Fix string8 to handle UTF-8 filenames on Linux

Reported by: Imarok Owned by:
Priority: Should Have Milestone: Alpha 22
Component: Core engine Keywords:
Cc: Patch: ​Phab:D518

Description (last modified by elexis)

We should fix string8 not displaying UTF-8 encoded OsPaths on Linux. Also see this todo at ​https://github.com/0ad/0ad/blob/master/source/lib/path.h#L138: 

// TODO: On Unixes, this will only be correct for ASCII or ISO-8859-1
// encoded paths; we should probably assume UTF-8 encoding by default
// (but take care to handle non-valid-UTF-8 paths safely).

Change History (2)

comment:1 by elexis, 7 years ago

Description: modified (diff)
Keywords: simple removed
Milestone: Backlog → Alpha 22
Patch: → Phab:D518

comment:2 by elexis, 7 years ago

Resolution: → fixed
Status: new → closed

In r19823:

Fix OsPath string8 function on Unix to account for characters that aren't covered by ISO-8859-1, thus allow proper printing of such paths.

Fixes #4647
Refs #4320 D518
Patch By: Philip
Tested By: Imarok on Windows, wraitii on OSX

Note: See TracTickets for help on using tickets.