Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#4648 closed defect (fixed)

[Patch] Capture The Relic victory shouldn't depend on the player ID order

Reported by: elexis Owned by: bb
Priority: Should Have Milestone: Alpha 23
Component: UI & Simulation Keywords:
Cc: Patch: Phab:D972

Description

As defined by CheckCaptureTheRelicCountdown and reported in Phab:D305#26811, the player with the lowest playerID that has mutually allied all players that own relics is marked as a winner in the CaptureTheRelic gamemode.

Example:

Player 1 is only mutual ally with 2. Player 2 is mutual ally with everyone but 8. Player 1 captures the relic and only 1+2 win.

Player 2 is only mutual ally with 1. Player 1 is mutual ally with everyone but 8. Player 2 captures the relic and everyone but 8 will be marked as winners (even if 2 had fought the entire game against player 3 to 7).

See replays attached there for an ingame test.

Change History (4)

comment:1 by bb, 6 years ago

Milestone: BacklogAlpha 23
Patch: D972
Summary: Capture The Relic victory shouldn't depend on the player ID order[Patch] Capture The Relic victory shouldn't depend on the player ID order

comment:2 by Adrián Chaves, 6 years ago

Patch: D972Phab:D972

comment:3 by bb, 6 years ago

Owner: set to bb
Resolution: fixed
Status: newclosed

In 21441:

Create winning teams for relic and wonder victory instead of letting all allies of a player win.

Create a getNonGaia function
Reset counters on playerDefeat
MarkPlayersAsWon function
Rename MarkPlayerAsWon to MarkPlayerAndAlliesAsWon
Stop letting winningplayers in relic depend on PlayerID

Comments By and Discussion With: elexis
Reviewed By: temple
Differential Revision: https://code.wildfiregames.com/D972
fixes #4648

comment:4 by elexis, 6 years ago

Keywords: simple removed

Thanks

Note: See TracTickets for help on using tickets.