Add tick box to let users not save password for lobby

[rugk]

Some users might not want to save the password at all, so please add a tick box (maybe off by default, so an opt-out) "Remember my password".

This is also somewhat security-critical. E.g. taking the following example as a thread model: On a shared, public computer (internet cafe) the admin is so nice to install 0ad (don't ask me whether this is realistic). There, obviously I do not want the next user of the system to login as me. This is only an example! There may be other reasons and situations (multiuser setup, no disk encryption, paranoia, whatever…) why users do not want to have their passwords saved.

Also another UX aspect: Currently I do not even know that my password is saved. So probably, I think I have to use an easy one or have to save it somewhere else, so that I do not lose access. However, when I see that checkbox, I see "Ah, right, it is saving my password. How nice.".

[Vladislav Belov]

Good idea, I was thought few days ago, how to reset my password without a reseting of all files. I could add it after the ​D770.

[rugk]

Mhh, but that does not seem to be connected to this issue, is not it? I mean to reset I would:

• click on "lobby"
• remove all characters
• enter new password

Actually, I also just saw, that you can just click on "cancel" in that window and it will take you back to a box "Login with existing or new account?". So as far as I see, you can already reset the password.

[Vladislav Belov]

Replying to rugk:

Mhh, but that does not seem to be connected to this issue, is not it? I mean to reset I would:

• click on "lobby"
• remove all characters
• enter new password

Actually, I also just saw, that you can just click on "cancel" in that window and it will take you back to a box "Login with existing or new account?". So as far as I see, you can already reset the password.

I need reset (make it empty), not the new password. So it doesn't work. In any way these actions are pretty bit messy and not obvious for players.

[rugk]

Ah, now I see what you mean. Basically you want to "logout" so the password is removed. Yes, that might be covered by this issue too.

[bb]

In r21311: Adds remember password checkbox

Reviewed By: elexis Differential Revision: ​https://code.wildfiregames.com/D822