#4772 closed defect (fixed)
Move ScriptFunctions to separate JS Interface files
Reported by: | elexis | Owned by: | elexis |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 23 |
Component: | Core engine | Keywords: | |
Cc: | Patch: |
Description
ScriptFunctions.cpp
defines C++ functions that can be called from the JS GUI.
The file is crowded and functions are not always logically grouped which is the contrary of good practice.
In May 2013, Yves and stwf started planning the SpiderMonkey Upgrade from 1.8.5 to v24 (#1886) in https://wildfiregames.com/forum/index.php?/topic/17289-discussion-spidermonkey-upgrade/
and designed the JS Interfaces to be split the way we see them currently committed.
leper recommended on irc on 2015-07-27 to split the VisualReplay
code to a separate JS Interface too.
Revision history of our current JSInterface
functions:
Date | commit | author | JS Interface |
2004-07-08 | r666 | Philip | GUITypes, IGUIObject |
2004-08-03 | r887 | markt | Camera, Console |
2005-05-02 | r2212 | janwas | VFS |
2013-06-06 | r13455 | stwf | Sound |
2013-09-12 | r13826 | Yves | Gameview |
2013-09-21 | r13877 | Yves | Renderer |
2013-11-16 | r14199 | Yves | Lobby |
2013-09-29 | r13914 | Yves | ConfigDB |
2014-04-20 | r14953 | gallaecio | Internationalization |
2014-08-25 | r15677 | leper | Mod |
2015-09-21 | r17055 | elexis | Visual Replay |
The project to compartmentalize ScriptFunctions.cpp
should be finished, so that the ScriptFunctions are more transparent and easier to extend.
Change History (14)
comment:1 by , 7 years ago
comment:3 by , 7 years ago
In r20164:
Move ReadJSONFile and WriteJSONFile GUI ScriptFunctions that only handle VFS paths to the VFS JS Interface.
comment:12 by , 7 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
In r20133:
Move VFS GUI script function registration to its interface file.