Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4779 closed task (fixed)

[PATCH] Projectile hit sound

Reported by: Mate-86 Owned by: Mate-86
Priority: Nice to Have Milestone: Alpha 23
Component: UI & Simulation Keywords:
Cc: Patch:

Description (last modified by Mate-86)

Enhancement of the missile hit sound handling:

  1. Allow the engine playing the sound using the position only (currently an entity is needed). A new cpp function should address that in SoundManager. This should fix the issue when the attacker dies before the projectile hits.
  2. Introduce different kind of sounds in the template:
    1. the projectile hits the target or the ground (melee hit belongs here)
    2. the projectile starts causing the damage itself (eg. explodes) (useful when the damage is delayed, related ticket: #1911)

Change History (5)

comment:1 by Mate-86, 3 years ago

Description: modified (diff)

comment:2 by Mate-86, 3 years ago

Owner: set to Mate-86
Status: newassigned

comment:3 by elexis, 3 years ago

Keywords: sound removed
Milestone: BacklogWork In Progress
Priority: If Time PermitsNice to Have
Summary: Projectile hit sound[PATCH] Projectile hit sound

comment:4 by fatherbushido, 3 years ago

Resolution: fixed
Status: assignedclosed

In 20236:

Add a new function to emit a sound from a position not attached to an entity. Use it to improve the attack impact sound code and allow to emit that sound even if the attacker died meanwhile. Use the sound provided by Pureon for catapult. Fix #4779.

Patch By: Mate-86
Differential Revision: https://code.wildfiregames.com/D921

comment:5 by fatherbushido, 3 years ago

Milestone: Work In ProgressAlpha 23
Note: See TracTickets for help on using tickets.