Opened 6 years ago

Closed 6 years ago

#4837 closed defect (fixed)

Wrong owner for docks on Migration

Reported by: mimo Owned by: elexis
Priority: Must Have Milestone: Alpha 23
Component: Maps Keywords:
Cc: Patch:

Description

Use for example the migration naval map, the owner of the initial dock is not the right one (it seems that the index is shifted by one unit).

Change History (2)

comment:1 by elexis, 6 years ago

Summary: Broken dock placement on random maps → Wrong owner for docks on Migration

Thanks for the report.

It's only on Migration. The only other random map placing docks this is Islands and that does it correctly.

In fact I noticed the error in my github branch too and fixed that in ​https://github.com/elexis1/0ad/commit/6c1ae1eb96cb1dc6cf8d82a4d4d6cf7e8f186ef5#diff-9ba28e18edcc6c97afab445820dbc2d8L186 but I didn't notice the mistake wasn't in that commit but in r20301.

comment:2 by elexis, 6 years ago

Owner: set to elexis
Resolution: → fixed
Status: new → closed

In 20408:

Fix wrong dock owner (off-by-1) in Migration in rP20301, fixes #4837.

Note: See TracTickets for help on using tickets.