Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#4857 closed defect (fixed)

Dropdown list invisible when dropdown is "low" on the screen

Reported by: bb Owned by: bb
Priority: Should Have Milestone: Alpha 23
Component: Core engine Keywords:
Cc: Vladislav Belov Patch: Phab:D1061

Description (last modified by Vladislav Belov)

When placing a dropdown in the gui that "low" such that the list doesn't fit in the space below the header, the list gets (partially) invisible, as seen in the screenshot: https://trac.wildfiregames.com/raw-attachment/ticket/4857/Screenshot%20from%202017-11-17%2016-52-30.png

Two solutions come to my mind here:

  • resize the list so it fits
  • create the list above instead of below

Probably a combination of the two would be best, like below if there is space for 2-3 items, otherwise above.

Attachments (1)

Screenshot from 2017-11-17 16-52-30.png (902.3 KB ) - added by bb 6 years ago.
screenshot

Download all attachments as: .zip

Change History (9)

by bb, 6 years ago

screenshot

comment:1 by bb, 6 years ago

Description: modified (diff)

comment:2 by Vladislav Belov, 6 years ago

Description: modified (diff)

comment:3 by bb, 6 years ago

Milestone: BacklogAlpha 23
Patch: D1061

comment:4 by Adrián Chaves, 6 years ago

Patch: D1061Phab:D1061

comment:5 by elexis, 6 years ago

Milestone: Alpha 23Work In Progress

I believe the problem on the screenshot was addressed by having the new gamesetup UI. Combining victory conditions is more interesting for alpha 23. If you still intend to finish it in alpha 23, feel free to.

comment:6 by bb, 6 years ago

Actually with the new UI the problem can occur, without changing the code (gametype page and select nothing and use the ceasefire dropdown), also patch ready for review.

comment:7 by bb, 6 years ago

Owner: set to bb
Resolution: fixed
Status: newclosed

In 21379:

Make sure dropdowns fit in the screen by allowing the list to be above when there is not enough space

Reviewed By: Vladislav
Differential Revision: D1061
fixes #4857

comment:8 by Stan, 6 years ago

Milestone: Work In ProgressAlpha 23
Note: See TracTickets for help on using tickets.