Fix possible mismatch between shown and actual victory condition

[Dunedan]

A week ago I encountered a bug playing a game on "Mediterranean Cove", where the displayed victory condition (=wonder) varied from the actual victory condition (=conquest).

From IRC (condensed to the relevant info):

<Dunedan> hey, what could be the issue that wonder is set for victory, but doesn't work?

<Dunedan> victory condition is "build & hold wonder for 20 minutes", but after building the wonder nothing happens

<Dunedan> around ~21min the wonder is finished

<elexis> "GameType":"wonder","VictoryScripts":["scripts/TriggerHelper.js","scripts/ConquestCommon.js","scripts/Conquest.js"]

<elexis> it must be a gamesetup bug

<bb1> yup got him

<bb1> select medit map

<bb1> change victory condition

<bb1> start game

<bb1> quit engine

<bb1> restart engine

<bb1> open gamesetup

<bb1> start game

<bb1> => bug

<bb1> the problem is that the skirm map sets the victory condition on new gamesetup instance but does not change the scripts

<bb1> so when scripts were wrong => bug

<bb1> but the map changes one value on gamesetup start

<bb1> and not another

<bb1> howtofix: calculate the scripts on loading game

<bb1> (iirc that is what i did in the combine vc, but needa check)

Replay is attached to this ticket.

[Dunedan]

replay of the match with victory condition mismatch

[bb]

Probably has been fixed by ​phab:rP21474, certainly fixed by ​phab:rP23374. The vicoryscripts are now calculated on launchgame instead of any other time.