Opened 6 years ago
Closed 2 years ago
#4949 closed defect (fixed)
Wrong order of lost/won messages ingame
Reported by: | Dunedan | Owned by: | |
---|---|---|---|
Priority: | If Time Permits | Milestone: | Alpha 26 |
Component: | UI – In-game | Keywords: | |
Cc: | Patch: | Phab:D4478 |
Description
At the end of a game messages are displayed about who won and who lost. For the sake of causality the cause should be displayed before the effect. So that a player lost should be displayed before the message that a player won, because loosing is the cause for the effect of winning.
As shown in the attached screenshot the order of messages is currently the other way around.
Attachments (1)
Change History (5)
by , 6 years ago
Attachment: | wrong_won_lost_order.png added |
---|
comment:1 by , 6 years ago
comment:2 by , 6 years ago
Same behavior for a22 and a23. Only difference is the added reason in a23.
IMO it seems nicer to have the winner message first, it's the first one to be read and the announcement that the winner is the new ruler of the land to be read first is what the player had earned, no?
I guess that is a matter of personal preferences. I'm confused everytime I see the winner mentioned first.
comment:3 by , 5 years ago
Component: | UI & Simulation → In-game UI |
---|
Move tickets to In-game UI
as UI & Simulation
got some sub components.
comment:4 by , 2 years ago
Milestone: | Backlog → Alpha 26 |
---|---|
Patch: | → Phab:D4478 |
Resolution: | → fixed |
Status: | new → closed |
Fixed in r26382.
Currently = alpha 22 or 23? We changed the code a bit in a23 (defeat reasons).
Does it have to reflect the causal order? IMO it seems nicer to have the winner message first, it's the first one to be read and the announcement that the winner is the new ruler of the land to be read first is what the player had earned, no? Especially when there are 4 losers and 4 winners.
The code is found in
EndGameManager.js
,MarkPlayerAsWon
.