Long range capturing

[temple]

If you attack as a formation with a formation that can attack as formation (currently phalanx, skirmish, syntagma, testudo, or wedge), and then while attacking switch to capturing, units will capture from where they stand rather than first moving to the proper range.

In the replay I show how the bug happens with the wedge formation but not close order.

[temple]

For the moment it might be best to disable attacking as formation, ​Phab:D1220.

[temple]

Formation attack uses the formation controller's position to determine if units are within range, and that's not necessarily correct. For example, a unit could be trapped between buildings but if it's still considered part of a formation it can attack with them, even if they're on the other side of the map. It also doesn't take into account the attack type so it'll return the same range whether they're attacking or capturing. (The code hasn't been updated in four years.)

[temple]

In 21042:

Disable attack as formation

Differential Revision: ​https://code.wildfiregames.com/D1220
Reviewed by: wraitii
Refs: #4951

[Imarok]

Move tickets to Simulation as UI & Simulation got some sub components.

[Silier]

issue is in this function ​https://code.wildfiregames.com/rP14633#inline-4843

[Freagarach]

Since r25235, they should only be able to attack once from too far away, since cmpAttack now checks for the range when actually attacking.

[Stan]

Backlogging due to lack of progress and Silier retiring.