Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#4958 closed defect (fixed)

Delete mysterious lSize lake area factor

Reported by: elexis Owned by: elexis
Priority: Should Have Milestone: Alpha 23
Component: Maps Keywords:
Cc: Patch:

Description

As discussed with bb and FeXoR here https://wildfiregames.com/forum/index.php?/topic/21370-random-map-code-library-math-function-shortcut-usefull-or-not/ and temple on irc yesterday:

There is an lSize area factor that is 1 for tiny maps and 1.25 for giant maps copied in few maps.

The strange part is that it doesn't scale linearily with the mapsize or maparea, but with the power of 1/8, i.e. the squareroot of the squareroot of the squareroot.

History:
r11137 Lake and Rivers (central lake area factor), r14108 (changed to radius factor, see #4957)
r11347 Canyon (central hill area factor)
r11361 Gulf of Botnhia (formerly gulf area factor), (r14160 changed to radius factor, see #4957), (one factor removed in r12545)
r11994 Oasis (unused comment), removed in rP0301
r12055 Gear (unused variable), removed in rP0301
r18714 Harbor (central lake area factor)
r12545, rP12654, rP12747 the Unknown maps (central lake ara, small central island lake ara, gulf lake area, passes central mountain, lowlands central valley area)

So the idea was in every instance to use that as an area factor.

It must be simplified so that noone will ever ask any question about the origin of the number.

Change History (2)

comment:1 by elexis, 6 years ago

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 20895:

Remove mysterious lake area factor "lSize" from random map scripts in rP11137 and copies. Fixes #4958.
Just use diskArea of a ratio of the map diameter everywhere, so numbers remain proportional and directly comparable.

comment:2 by elexis, 6 years ago

In 20973:

Pass a vector to createStoneMineFormation, refs #4992.

On India,
remove another mysterious lake size area factor on India, refs #4958,
increase the lakesize on small maps and
simplify constraints.

Note: See TracTickets for help on using tickets.