#4992 closed defect (fixed)
Use vectors not only in rmgen scripts but also for arguments in the rmgen library
Reported by: | elexis | Owned by: | elexis |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 23 |
Component: | Maps | Keywords: | |
Cc: | Patch: |
Description
Since now (#4845) most of the maps use vector algebra to simplify equations by a lot, the basic rmgen tools should also use vectors when passing arguments. This way the vector objects have only to be created once and can be passed back and forth, it's globally consistent.
Also it was likely envisioned once upon a time by the point.js
file from r9096. That commit also introduced the Vector.js
code but somehow didn't use it.
For instance:
- Placers
- Painters
- Constaints
- Areas
- getHeight, setHeight
- placeObject
Change History (21)
comment:1 by , 6 years ago
comment:3 by , 6 years ago
I'm aware that there's a performance cost to creating the vectors and that in some cases we don't have a vector yet. However that's a fraction of a second in any case currently. The thing that costs performance are the retries and some unluckily chosen numbers for the ClumpPlacer.
In r20936:
Use vectors for positions in setHeight in random map scripts.
comment:12 by , 6 years ago
comment:19 by , 6 years ago
Milestone: | Backlog → Alpha 23 |
---|---|
Owner: | set to |
Priority: | Nice to Have → Should Have |
In 20935: