Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#5068 closed enhancement (fixed)

Use victory conditions json's in Atlas

Reported by: bb Owned by: Stan
Priority: Should Have Milestone: Alpha 24
Component: Atlas editor Keywords:
Cc: Patch: Phab:D2393

Description (last modified by bb)

Atlas currently hardcodes the victoryConditions in map.cpp (to create its checkboxes). This makes adding new victory conditions more work than it should. It should read all required data from the json in the public mod (like gamesetup does). This should also include the disabling and unchecking of conquest_structures{units} when conquest is checked (so we can nuke OnConquestChanged in map.cpp).

related #5075

Change History (4)

comment:1 by bb, 6 years ago

Description: modified (diff)

comment:2 by Stan, 4 years ago

Milestone: BacklogAlpha 24
Patch: Phab:D2393

comment:3 by Stan, 4 years ago

Owner: set to Stan

comment:4 by Stan, 4 years ago

Resolution: fixed
Status: newclosed

In 23847:

Use victory conditions json's in Atlas

Reviewed by: @Angen

Differential Revision: https://code.wildfiregames.com/D2393

In P23881:

Fix Atlas crash introduced by rP23847

Reviewed by: @Angen @vladislavbelov

Differential Revision: https://code.wildfiregames.com/D2898

Last edited 4 years ago by Stan (previous) (diff)
Note: See TracTickets for help on using tickets.