Opened 6 years ago

Last modified 11 months ago

#5069 new enhancement

XML_Element macro redeclares a variable

Reported by: Itms Owned by:
Priority: Nice to Have Milestone: Backlog
Component: Core engine Keywords:
Cc: Patch:

Description

The macro defined in ps/trunk/source/ps/XML/XMLWriter.h#L80 redefines xml_element_ which can hide previous definitions of the variable in case xml elements are nested.

A fix proposed by Vladislav was to create the element as xml_element_##name but all the other macros access xml_element_, so in order to work that would need rewriting all those macros.

Change History (2)

comment:1 by Itms, 6 years ago

In 21480:

Fix compiler warnings on VS 2015, refs #3439, refs #5069.

Patch By: Stan
Reviewed By: Itms, vladislavbelov
Differential Revision: https://code.wildfiregames.com/D1262

comment:2 by Silier, 11 months ago

Cc: Silier removed
Note: See TracTickets for help on using tickets.