Changes between Initial Version and Version 1 of Ticket #5092


Ignore:
Timestamp:
Mar 23, 2018, 12:18:40 AM (6 years ago)
Author:
Inari
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #5092 – Description

    initial v1  
    88So it can't just check that failed variable against the size multiplied by `failFraction`. It should instead keep track of how many points it tried to put and multiply that count by `failFraction` to check against `failed`.
    99
    10 ChainPlacer seems to do this already ([source:ps/trunk/binaries/data/mods/public/maps/random/rmgen/placer/centered/ChainPlacer.js#L110])
     10ChainPlacer seems to do this already ([source:ps/trunk/binaries/data/mods/public/maps/random/rmgen/placer/centered/ChainPlacer.js#L110]).
     11
     12This is also why #4810 seemed to be an issue, originally it passed a `failFraction` of 1, allowing for placement to proceed in any case. But that seems to not have worked as intended.