Regicide victory condition error

[mimo]

Using the following autostart on r21669

pyrogenesis -autostart=random/mainland -autostart-seed=5137 -autostart-aiseed=4193 -autostart-players=4 -autostart-ai=1:petra -autostart-civ=1:brit -autostart-ai=2:petra -autostart-civ=2:mace -autostart-ai=3:petra -autostart-civ=3:iber -autostart-ai=4:petra -autostart-civ=4:maur -autostart-nonvisual -autostart-victory=regicide

Player 2 is defeated at turn about 12000, but some of its entities do not turn to gaia and it still owns 25% of the territory at the end game as shown in the printed statistics (remove the -autostart-nonvisual to visualize the game).

[elexis]

Sounds like #4384, but in that ticket the buildings aren't owned, only capture points remaining on buildings of another owner. When that other owner is defeated, the buildings can turn into that originally defeated player.

[mimo]

Not sure it is similar to #4384. From what i've seen (looking at the ai side but should be the same on the simu side), one civ center (id=150) was owned by gaia. Player 2 was capturing it and captured it 2 turns before being defeated. But it was not turned back to gaia on player defeated.

Concerning #4384, you should put it on phab as it fixes some real potential problems. The patch itself looks good, except that i don't understand why you only turn cp points to gaia for structures not owned by the defeated players. You could do it for all?

Edit: OK OnOwnershipChanged of Capturable reset the cp points. So forget my last point.

[elexis]

It is #4384.

I could not reproduce it by capturing it and resigning on the same turn or 2 turns later.

I've done the visual replay of it (same command, just remove the nonvisual argument and add -autostart-player=-1).

150 is the yellow players CC. 12000 = 60min Yellow was defeated somewhere at min 35. Blue was slowly capturing it by territory. At about min 38, the red player took over the territory. At min 41, the red player lost it's hero, while the CC is still gaia owned, has like 13 CP gaia, about 10 of blue and 98% of red (which is exactly the bug in the linked ticket). Then the remaining gaia capture points are lost and since red had most capture point, the building goes to red and red willingly continues to play post mortem.

(One can pull this in an actual game on purpose, but it is difficult and no matter how well one plays, one will always count as defeated)

[mimo]

Yes, i mixed things because the ai defeated players was only effective when the cc switched to player 2 (ai is not run when no entities). So that's a dupplicate, i agree.

But then #4384 should be moved to a23. The problem is not that you may resurrect, but that it's an unexpected behaviour which 1) will be reported as bug 2) messed up the rest of the game (i think you've noticed ai warnings in your replay).