Opened 6 years ago

Last modified 5 years ago

#5125 assigned enhancement

[PATCH] Increase contrast of water reflections

Reported by: aeonios Owned by: aeonios
Priority: Nice to Have Milestone: Backlog
Component: Core engine Keywords:
Cc: Patch: Phab:D1451

Description

Objects reflected in water tend to look washed out and shadows don't show up well, so I added a contrast filter and a saturation adjustment to color correct them.

Attachments (1)

water_contrast.patch (1.3 KB ) - added by aeonios 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by OptimusShepard, 6 years ago

Thx for patch. Please upload it to phabricator for reviewing

https://code.wildfiregames.com/

comment:2 by aeonios, 6 years ago

Alright this is now on phabricator. I'll post screen shots when I can get that working.

comment:3 by aeonios, 6 years ago

Updated to account for https://code.wildfiregames.com/D1402 and included some minor tweaks.

by aeonios, 6 years ago

Attachment: water_contrast.patch added

comment:4 by OptimusShepard, 6 years ago

Thx for uploading to phabricator. It's not nessesary to update the patches here. The whole programming process is on phabricator. The staffs will take them directly from phabricator when they had accepted the patch. On trac you only mark the ticket as your own, that people see that someone is working on that ticket.

comment:5 by Imarok, 6 years ago

Patch: Phab:D1451

comment:6 by s0600204, 6 years ago

Milestone: Alpha 23Alpha 24

Hi, we're in feature freeze right now, and this looks to be non-critical. Thus, I'm bumping this back to Alpha 24.

If you feel this is incorrect, and that this change must be included in Alpha 23, please provide your reasoning.

Thank you for your contribution to 0 A.D.!

comment:7 by Imarok, 5 years ago

Component: UI & SimulationCore engine

Move tickets to their correct component.

comment:8 by wraitii, 5 years ago

Milestone: Alpha 24Backlog

Going to backlog this as r22607 fixed a related issue that makes this less necessary. The code can still be improved graphics-wise, thus not entirely fixing this ticket.

Note: See TracTickets for help on using tickets.