Opened 6 years ago

Last modified 2 years ago

#5179 new defect

.DELETED folders are not taken into account when mods are packaged

Reported by: Stan Owned by:
Priority: Should Have Milestone: Backlog
Component: Core engine Keywords:
Cc: Patch:

Description

Steps to reproduce:

  • Download the following packaged mod: 
http://www.mediafire.com/file/3h756hjh0ga4uck/ponies_ascendant.pyromod
  • Install it
  • Notice all civs appears in the gamesetup while only 3 should appear as there is a civs.DELETED file in there.
  • Go to the mod location see GameDataPaths
  • Extract its contents (remove the zip file afterwards)
  • Notice there are now only 3 civs in gamesetup.

Attachments (1)

deleted_mod_test.zip​ (195.2 KB ) - added by Stan 6 years ago.
Minimal mod. Deletes all the skirmishes maps except one (Else gamesetup dies)

Download all attachments as: .zip

Change History (12)

comment:1 by Stan, 6 years ago

Summary: .DELETED folders are not removed when packaged → .DELETED folders are not taken into account when mods are packaged

comment:2 by Imarok, 6 years ago

refs #1110

comment:3 by fcxSanya, 6 years ago

I can't reproduce this with A23 on Windows 8: on the second step ("Notice all civs..."), I see only 3 pony civs: ​https://i.imgur.com/09TS9cd.png

I also tried to make my own test mod which hides the standard maps, and it seem to be working fine either packaged and not packaged.

comment:4 by Stan, 6 years ago

Mmmh. Might be that I'm using SVN ?

Maybe installed version has different paths. Or that archive generated paths are different.

Last edited 6 years ago by Stan (previous) (diff)

comment:5 by Imarok, 6 years ago

Maybe both of you want to upload a minimal testcase mod (like removing all maps), so that everyone (including you) could test it?

by Stan, 6 years ago

Attachment: deleted_mod_test.zip​ added

Minimal mod. Deletes all the skirmishes maps except one (Else gamesetup dies)

comment:6 by Stan, 6 years ago

In S.V.N.

  • S.V.N. Extracted version (binaries/data/mods)... Success.
  • S.V.N. Zipped version in game install folder (binaries/data/mods)... Failure.
  • S.V.N. Extracted version in game mods folder (Documents/my games/0ad/mods)... Success.
  • S.V.N. Zipped version in game mods folder (Documents/my games/0ad/mods)... Failure.
Last edited 6 years ago by Stan (previous) (diff)

comment:7 by Stan, 6 years ago

A23:

  • A23 Extracted version (binaries/data/mods)... Success.
  • A23 Zipped version in game install folder (binaries/data/mods)... Success.
  • A23 Extracted version in game mods folder (Documents/my games/0ad/mods)... Success.
  • A23 Zipped version in game mods folder (Documents/my games/0ad/mods)... Success.

Packaged mods can only delete files from packaged mods.

Extracted mods can delete files from packaged and not packaged mods.

Last edited 6 years ago by Stan (previous) (diff)

in reply to:  7 comment:8 by Imarok, 6 years ago

Replying to stanislas69:

A23:

  • A23 Extracted version (binaries/data/mods)... Success.
  • A23 Zipped version in game install folder (binaries/data/mods)... Success.
  • A23 Extracted version in game mods folder (Documents/my games/0ad/mods)... Success.
  • A23 Zipped version in game mods folder (Documents/my games/0ad/mods)... Success.

Packaged mods can only delete files from packaged mods.

Extracted mods can delete files from packaged and not packaged mods.

Nice investigation. So it's not that bad broken...

comment:9 by Stan, 6 years ago

Yeah only an inconvenience

comment:10 by Imarok, 5 years ago

Component: UI & Simulation → Core engine

Move tickets to their correct component.

in reply to:  7 comment:11 by Langbart, 2 years ago

Replying to stanislas69:

Packaged mods can only delete files from packaged mods.

Extracted mods can delete files from packaged and not packaged mods.

I could reproduce it as well.
I unzipped the public.zip while mod with a .DELETED file was packaged.

After unzipping the packaged mod, the problem was solved.

Note: See TracTickets for help on using tickets.