#5186 closed defect (fixed)
OOS after rejoin - territory differences on square maps
Reported by: | temple | Owned by: | temple |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 23 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: | Phab:D1555 |
Description (last modified by )
fpre and Palaiologos shared oos logs that were similar to the KunstRaucher ones in #5162 (territory of some trees and grasses was different), but I was able to reproduce theirs with rejointest after recreating the map in atlas. I think the attached is for turn 10.
Attachments (1)
Change History (13)
by , 6 years ago
Attachment: | latium.zip added |
---|
comment:1 by , 6 years ago
Milestone: | Backlog → Alpha 24 |
---|---|
Priority: | Must Have → Release Blocker |
comment:3 by , 6 years ago
Description: | modified (diff) |
---|
comment:4 by , 6 years ago
Is this a self-correcting OOS and thus primarily occurs within the first 20 turns?
comment:5 by , 6 years ago
No, the cost grid remains all 1's (ignores terrain) throughout the game for the initial players while rejoiners have territories adjusted for terrain.
comment:6 by , 6 years ago
Patch: | → Phab:D1555 |
---|
comment:7 by , 6 years ago
Milestone: | Alpha 24 → Alpha 23 |
---|
comment:9 by , 6 years ago
Summary: | OOS after rejoin - territory differences → OOS after rejoin - territory differences on square maps |
---|
comment:10 by , 5 years ago
Milestone: | Alpha 23 → Alpha 24 |
---|---|
Priority: | Release Blocker → Must Have |
Resolution: | fixed |
Status: | closed → reopened |
21835 was a hotfix which did not fix the bug.
comment:11 by , 5 years ago
Milestone: | Alpha 24 → Alpha 23 |
---|---|
Resolution: | → fixed |
Status: | reopened → closed |
I'd prefer to keep the resolved OOS tickets on this milestone, if it's just for finding it historically.
Please always post the task when opening a ticket, I guess you refer to https://code.wildfiregames.com/rP21675#30839 (and set the upcoming milestone only if you know someone who will work on it then).
comment:12 by , 5 years ago
More or less. Also the fact that if I think I read something wrong.
SetPassabilityCircular
is called with false as square maps should, the game would still go oos. Would it not?
After some investigation with elexis, we found Phab:rP21675 responsible. In particular, on square maps (like latium) starting players see territories that ignore passability concerns, while rejoining players see territories that adjust for hills, etc. That's why the rejoining players have the trees in gaia territory rather than player territory.
(However, I haven't yet digested the code to explain why it fails only on square maps. The KunstRaucher replay from #5162 is a similar oos and on the circular mainland map, but we couldn't reproduce it with rejointest.)