Opened 6 years ago

Closed 6 years ago

#5198 closed defect (fixed)

OOS on rejoin on Danubius

Reported by: elexis Owned by: elexis
Priority: Release Blocker Milestone: Alpha 23
Component: Maps Keywords:
Cc: Patch: ​Phab:D1548

Description

As reported by temple in #5162, r20957 introduced serialized vectors. But as reported in #4698, vectors lose their prototype functions, so the math functions can't be called.

So when someone rejoins a Danubius map and ships want to ungarrison, there will be an error, ships don't receive their order and it will be OOS.

This issue can be fixed for the alpha 23 rerelease and won't worsen the game under any condition as pointed out in ​Phab:D1548.

Change History (1)

comment:1 by elexis, 6 years ago

Owner: set to elexis
Resolution: → fixed
Status: new → closed

In 21834:

Fix an OOS on rejoin on Danubius following rP20957, refs #4855, fixes #5198.

Vectors are still deserialized as objects without their prototype functions, so doing math on these obejcts fails upon rejoin, refs #4698.
This patch doesn't add any version incompatibilities and players with the patched version can successfully rejoin unpatched games.

Differential Revision: ​https://code.wildfiregames.com/D1548
Reviewed By: temple

Note: See TracTickets for help on using tickets.