Opened 6 years ago

Last modified 3 years ago

#5210 new defect

Replace NetServer breakpoints with error messages and disconnect

Reported by: elexis Owned by:
Priority: Should Have Milestone: Backlog
Component: Network Keywords: simple
Cc: Patch:

Description

It's possible to send messages with the NetClient when the NetServer didn't expect them. This triggers debug breakpoints (ENSURE, #3643) or LOGERROR messages (including FSM errors, #3199, #4594).

At least the breakpoints should be removed with a LOGERROR and disconnect as done in #3643, so that malevolent clients can't cause any damage to players.

The other LOGERROR calls, such as the Error running FSM update may be considered to receive a disconnect as well. If clients are getting disconnected more often they might take reporting the FSM error more seriously.

Change History (4)

comment:1 by Silier, 4 years ago

Milestone: BacklogWork In Progress
Owner: set to oslogard

comment:2 by Silier, 4 years ago

Milestone: Work In ProgressBacklog
Owner: oslogard removed

no updates

comment:3 by Silier, 3 years ago

Keywords: simple removed
severity: simple

comment:4 by Silier, 3 years ago

Keywords: simple added
Note: See TracTickets for help on using tickets.