Opened 6 years ago

Closed 5 years ago

#5222 closed defect (fixed)

XML Syntax errors should be seen at least once per application start

Reported by: elexis Owned by: elexis
Priority: Must Have Milestone: Alpha 24
Component: Core engine Keywords:
Cc: Patch: ​Phab:D1574

Description

As reported by gameboy in ​https://wildfiregames.com/forum/index.php?/topic/24480-svn21848-error/ r21847 came with a syntax error in credentials.xml.

The XML library saves syntactically correct cached versions of syntactically incorrect XML files, so we see the error the first time, but then never again.

So if a dev has some errorspam and only read the first error, he may never have a chance to read this error and is mislead to believe that the XML files are syntactically and semantically correct and commit them. 

Change History (2)

comment:1 by elexis, 6 years ago

In 21849:

Fix XML syntax error in rP21847 reported by gameboy.

The error was hidden by Xeromyces loading the syntactically correct XMB file that is still written for syntactically wrong XML files, refs #5222, D1574.

comment:2 by elexis, 5 years ago

Owner: set to elexis
Resolution: → fixed
Status: new → closed

In 22921:

Reliably report and reject invalid XML files following rP16733, refs #245, fixes #5222.

Don't write XMB files for XML files that failed the validation, otherwise the XML validation error will not be reported on consecutive program starts anymore (as the XMB is loaded, skipping validation).
This had resulted in invalid XML going unnoticed and committed in credentials.xml in rP21847.

Differential Revision: ​https://code.wildfiregames.com/D1574
Reported by: gameboy
Comments By: bb
Tested on: clang 8.0.1, Jenkins

Note: See TracTickets for help on using tickets.