Opened 14 years ago
Closed 13 years ago
#523 closed task (fixed)
Implement SDL_GL_SWAP_CONTROL on Windows
Reported by: | Philip Taylor | Owned by: | janwas |
---|---|---|---|
Priority: | If Time Permits | Milestone: | Alpha 2 |
Component: | Core engine | Keywords: | simple |
Cc: | Andrew | Patch: |
Description
ps/VideoMode.cpp
does SDL_GL_SetAttribute(SDL_GL_SWAP_CONTROL, ...)
to set vsync.
On Windows we emulate the SDL API, and don't support that attribute. ps/GameSetup/GameSetup.cpp
uses WGL_EXT_swap_control
instead. That OS-specific code ought to be moved into lib/sysdep/os/win/wsdl.cpp
to implement the standard SDL attribute.
Attachments (1)
Change History (8)
by , 14 years ago
Attachment: | SDLGLSWAPCONTROLWIN.patch added |
---|
comment:2 by , 14 years ago
A few things:
Rather than using the low-level GL APIs, this should just use the existing ogl_HaveExtension
/pwglSwapIntervalEXT
like GameSetup.cpp
does. Also the patch should remove that code from GameSetup.cpp
.
The "// not implemented yet
" comment in wsdl.h
should be removed.
What does the comment
// We should not have to call this here but since our code is not really friendly // this will have to do!.
mean?
comment:3 by , 14 years ago
Cc: | added |
---|
(Adding CC since I just realised you might not be notified of changes here)
comment:5 by , 13 years ago
Milestone: | → OS Alpha 2 |
---|---|
Owner: | set to |
comment:6 by , 13 years ago
Owner: | changed from | to
---|
comment:7 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Patch for enable disable VSync Windows