Common C++ issues were found by PVS-Studio

[Vladislav Belov]

From ​https://wildfiregames.com/forum/index.php?/topic/24742-i-found-19-simple-issues-in-c-code/

​https://www.viva64.com/en/b/0581/

There are three kind of errors:

• main pyrogenesis code
• internal pyrogenesis libraries (the biggest set of errors)
• third-party libraries

N1: ​Here

N2: ​Here

N3: ​Here

N4: Code no longer exists. Since [23364]

N5: ​Here

N6: ​Here

N7, N8: ​Here

N9, N10, N11: ​Here

N12: ​Here

N13: Code no longer exists ​Here

N14, N15: ​Here

[Stan]

In 23029:

Cleanup CCmpRallyPointRenderer

Replace std::deque by std::vector
Replace some casts by cpp casts
Move the class and struct declaration to a separate file for clarity.
Fixes rP10704 by removing offending function
Refs #5288
Refs D1681

Reviewed by: @vladislavbelov

Differential Revision: ​https://code.wildfiregames.com/D1682

[Vladislav Belov]

In 24903:

Fixes leaking of a file handle in case of an error. Refs #5288

Reported By: PVS-Studio

[Vladislav Belov]

In 24905:

Fixes UB in shared_ptr usage of an array. Refs #5288

Reported By: PVS-Studio

[animus]

Adding completed tasks to the ticket for easier tracking.

[phosit]

Add commit when N4 was removed. sera found it because sera knows git better than me ;).

[animus]

Removed "Awaiting review" and made it easier on the eyes.

[animus]

N13's function was missing, added the changeset in which it was removed.

[animus]

prettify

[animus]

N14, N15 are no longer present.

[Itms]

In 27647:

Check the validity of a couple pointers in low-level tests, refs #5288.

Reported By: PVS-Studio
Patch By: animus
Reviewed By: phosit

Differential Revision: ​https://code.wildfiregames.com/D4994

[phosit]

In 27751:

Change %c to %lc for wchar arguments.
swprintf_s expected an argument of type char (due to %c). Given an argument of type wchar.
This fixes N7 and N8 from #5288

Refs #5288

Patch By: @animus

Accepted By: @phosit, @vladislavbelov

Differential Revision: ​https://code.wildfiregames.com/D4993

[phosit]

In 28014:

Don't check memory allocation made using new

Refs: #5288

Patch By: @animus
Accepted By: @phosit
Comments By: @vladislavbelov

Differential Revision: ​https://code.wildfiregames.com/D5234