Changes between Initial Version and Version 1 of Ticket #52, comment 29


Ignore:
Timestamp:
Jun 15, 2014, 3:45:58 PM (10 years ago)
Author:
sanderd17

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #52, comment 29

    initial v1  
    66||Triggers for random maps||I have no doubt that there's at least one sensible way to use triggers from random map scripts with the current system. I think there are even many ways it could be done, so it would make sense to figure it out and add an example implementation.||Trigger System||TODO||
    77||TriggerHelper.SpawnUnits: Error handling||if !cmpPosition, it prints warnings but still creates all the entities. Shouldn't that be considered an error and shouldn't it abort the function?||Trigger System||TODO||
    8 ||Typo||„the“ should be removed from „Spawn units from the all trigger“||Trigger System||TODO||
    98||Separate examples||Please remember to separate the examples from the main commit.||Trigger System||TODO||
    109||Trigger.prototype.RemoveRegisteredTriggerPoint: Error handling||Some error handling would be good instead of silently ignoring if there's no matching ref or ent||Trigger System||TODO||
    11 ||Typo||Trigger.prototype.DisableTrigger: Warning message should say „Disabling“ instead of „Enabling“||Trigger System||TODO||
    1210||Documentation on the wiki||Good documentation is especially important in this case if we want many new mission scripts from map designers and modders! :)||Trigger System||TODO||
    13 ||Style||Extra line in Damage.js||Trigger System||TODO||
    14 ||Tutorial text ||„Food, Wood, Stone and metal“: wood and stone should start with a lower case letter. „Resource gathering play a central role“ should be „plays“||Basic tutorial||TODO||
    15 ||Rider in basic tutorial||There's no rider in the basic tutorial (and horseman would probably be the better term... but I'm not sure)||Basic tutorial||TODO||
    1611||Translation support for the trigger scripts in general||TriggerHelper.PushGUINotification does not support translated messages. If we extend it to support that too, it basically becomes a wrapper around PushNotification from the GUIInterface component with the only difference that the mission scripter doesn't have to query the interface for a GUIInterface component. Is it even worth a helper function in this case? Should we keep the current helper function for untranslated messages?||Trigger System||TODO||
    1712||Translation support for basic tutorial||If not in the first patch, we should at least add translation support for the tutorial later.||Basic tutorial||TODO||
    18 ||trigger templates not properly included in patch||"The following files aren't properly included in the patch; binaries/data/mods/public/simulation/templates/special/trigger_point_A.xml, binaries/data/mods/public/simulation/templates/special/trigger_point_B.xml, binaries/data/mods/public/simulation/templates/template_trigger_point.xml Please add them for the review and make sure they have the correct properties set before committing"||Trigger System||TODO
     13
     14Stuff solved:
     15
     16||'''Title'''||'''Description'''||'''Part'''||'''Type'''||
     17||Typo||Trigger.prototype.DisableTrigger: Warning message should say „Disabling“ instead of „Enabling“||Trigger System||DONE||
     18||Style||Extra line in Damage.js||Trigger System||DONE||
     19||Rider in basic tutorial||There's no rider in the basic tutorial (and horseman would probably be the better term... but I'm not sure)||Basic tutorial||INVALID||
     20||Typo||„the“ should be removed from „Spawn units from the all trigger“||Trigger System||DONE||
     21||trigger templates not properly included in patch||"The following files aren't properly included in the patch; binaries/data/mods/public/simulation/templates/special/trigger_point_A.xml, binaries/data/mods/public/simulation/templates/special/trigger_point_B.xml, binaries/data/mods/public/simulation/templates/template_trigger_point.xml Please add them for the review and make sure they have the correct properties set before committing"||Trigger System||DONE||
     22||Tutorial text ||„Food, Wood, Stone and metal“: wood and stone should start with a lower case letter. „Resource gathering play a central role“ should be „plays“||Basic tutorial||DONE||