Changes between Initial Version and Version 1 of Ticket #52, comment 36


Ignore:
Timestamp:
Jun 21, 2014, 3:47:38 PM (10 years ago)
Author:
Yves

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #52, comment 36

    initial v1  
    11I'm through with the review. I have not checked every line in the patch very carefully, but I'm confident that I found most of the issues.
    22
    3 I have reported all the issues I found including minor one like typos. So let sum it up on a higher level.
     3I have reported all the issues I found including minor ones like typos. So let's sum it up on a higher level.
    44
    55The main thing we wanted to avoid is including many new maps that all have to be changed or completely redone later because the trigger system changes too much. I think we can be confident enough that this will not happen with the trigger system as a whole because this solution is very flexible and we have prove of concept implementations or at least rough design ideas for all known uses cases. Some additional thoughts on that topic: