Opened 5 years ago

Last modified 5 years ago

#5320 new defect

Remove rating from nickname

Reported by: elexis Owned by:
Priority: Should Have Milestone: Backlog
Component: Network Keywords:
Cc: Patch:

Description

There have been a number of issues with the lobby rating being part of the playername in multiplayer matches.

In a number of places in the networking related code, the rating has to be removed from the nickname again in order to compare the playername.

For example:

  • buddy system (comparing if the player is a buddy, adding a buddy from within a match)
  • banning ​Phab:D1655 (needs banmask to ignore the rating postfix)
  • rejoin success depends on rating not having changed meanwhile r19828 / #3686
  • average playerrating of the match needs splitRatingFromNick
  • acoustic nick notification needs splitRatingFromNick
  • selectGameFromPlayername needs splitRatingFromNick
  • late observer rejoin for buddies needs splitRatingFromNick

Notice there are advantages from having the rating within the nickname:

  • gamesetup, session, summary, replaymenu and more gui pages don't need to construct the playername just-in-time
  • autocompleting playernames also includes the rating

Change History (1)

comment:1 by elexis, 5 years ago

In 21918:

Use a banmask for multiplayer matches that have lobby-authentication enabled.
This prevents a lobby player banned by the host from rejoining after getting a new IP address and changing the rating part of the nickname, refs #5320, #3241 / rP17217, #3549 / rP21520 / D897.

Differential Revision: ​https://code.wildfiregames.com/D1655
Reproduced By: Hannibal_Barca

Note: See TracTickets for help on using tickets.