Opened 9 months ago

Last modified 3 days ago

#5322 new defect

Object orientation gamesetup rewrite

Reported by: elexis Owned by:
Priority: Must Have Milestone: Backlog
Component: UI – Game setup Keywords:
Cc: Krinkle Patch:

Description

#3994 / r19504 / Phab:D322 has unified all gamesetup dropdowns, checkboxes and some miscellaneous GUI objects.

There are still about 1900 lines of code that are in procedural style and use global variables where they could use local variables.

This will be the precondition for future work on the gamesetup, for intsance:

  • sliders in the gamesetup (for example ceasefire duration)
  • map specific gamesetup options #4838 (for example day/night variant on danubius or water-level-rise-time on extinct volcano)
  • anything

It will also make it more obvious to gamesetup developer that procedural code is not the right way to keep this massive GUI page grouped by logic.

Change History (3)

comment:1 Changed 9 months ago by elexis

In r21882:

Gamesetup cleanup.

Move civInfo press event handling from XML to the JS GUI object data from rP19504 / D322. Equally move civInfo tooltip from init (which should remain agnostic of content) following rP21339 / D846, refs #4970.

comment:2 Changed 4 months ago by Imarok

Component: UI & SimulationGame setup

Seems like that flew under my radar.

comment:3 Changed 3 days ago by Krinkle

Cc: Krinkle added
Note: See TracTickets for help on using tickets.