Opened 4 years ago

Last modified 4 years ago

#5371 assigned defect

Population Cap and Starting Resources for Scenarios

Reported by: Wundersam Owned by: Wundersam
Priority: Should Have Milestone: Backlog
Component: Simulation Keywords:
Cc: Patch: Phab:D1704

Description

Hi, I'd like to get started with 0ad development and I found myself a bug in the current svn I'm confident to fix.

The dropdowns for Population Cap and Starting Resources will be disabled if a scenario type map is selected. However, both settings won't be set to any specific value when switching from a non-scenario map to a scenario map.

Regarding the population cap, playing the scenario with an arbitrary cap is possible by selecting it before switching to a scenario type map. Regarding the starting resources, they will show up as selected before switching to a scenario type map but will always be 300 ingame. Concerning the starting resources, I would make sure that they show up with the value that will be used ingame – I will try to look up whether that's a hardcoded default of 300 or map-dependent in some way. Concerning the population cap, however, it is not clear whether they're supposed to be fixed (like starting resources) or variable like for other game types in which case the simple fix might be "enabled": () => true in gamesetup.js:606.

I'd appreciate if I could keep this bug assigned to get this fixed myself as soon as I know what the intention for the population cap was. My opinion: Let the player pick the population limit because it's performance relevant.

Attachments (1)

cap.png (929.5 KB ) - added by Wundersam 4 years ago.
How to reproduce in the game setup screen

Download all attachments as: .zip

Change History (4)

by Wundersam, 4 years ago

Attachment: cap.png added

How to reproduce in the game setup screen

comment:1 by Wundersam, 4 years ago

Patch: Phab:D1704

comment:2 by elexis, 4 years ago

The dropdowns for Population Cap and Starting Resources will be disabled if a scenario type map is selected.

As intended, 'won't fix' as far as I see.

This issues are on the one hand #4504 (scenario providing a different format for starting resources) and what sounds like the class of "persist-matchsettings" bugs, which equally happen when changing the mapselection for some maps.

We have at least four generations of developers that have failed in various ways with the gamesetup and gamesettings model. There are different ideas floating around how to persist user-settings (in between matches and in between mapselection), how to combine the different data sources (settings of the current map, settings of the previously selected map, settings that the user specified), when to overwrite the settings, when to delete settings, for example in #3883. #5322 will refactor the gamesetup code a lot more, but the persist-setting issues remain. It will need a model redesign first, so it might affect the code in the most of the current g_Dropdowns / g_Checkboxes code in the worst case.

So to me this ticket sounds like three aspects:

  • won't fix: changing pop cap in scenario maps; or justified gamesetup redesign
  • duplicate: gamesetup is a mess
  • TO FIX: gamedescription.js shows wrong data sometimes

comment:3 by Imarok, 4 years ago

Component: UI & SimulationSimulation

Move tickets to Simulation as UI & Simulation got some sub components.

Note: See TracTickets for help on using tickets.