Opened 5 years ago

Last modified 4 years ago

#5444 new defect

Missing credits

Reported by: elexis Owned by:
Priority: Should Have Milestone: Backlog
Component: UI – Miscellaneous Keywords:
Cc: Patch: Phab:D2436

Description (last modified by elexis)

See also the comments in Phab:D2436 for further detail.

  • One should be able to identify more by going through the forum list of staff members, the interviews with candidates on IRC, IRC log searches for the credit keyword etc., the revision history
  • Credits are not so much optional, but required for copyright if one wants to ask for relicensing of the code if there is ever the wish to reuse the code differently. For example if someone wants to link the game against the Steam library, then one can try to ask all contributors.

(Credits are also legally relevant for copyright, so it seems wrong to put it into the user-interface component)

2009-08-12-QuakeNet-#0ad.log:

16:26  * Philip- ignores the licensing stuff for now, and just commits cygal's patch
16:31 < cygal> thanks for the commit :)
16:31 <@Philip-> Hmm, I suppose it'd also be useful to have a list of contributors' names, to go in the credits screen etc
16:32 <@Philip-> It's hard enough keeping track of all the official WFG members who've contributed :-(
16:32  * Philip- wonders if cygal has a real name he could add to the list, and maybe an email address if he doesn't mind it being public
16:33 < cygal> Quentin Pradet <email redacted>
16:33 < cygal> (but I don't really care about credits)

Change History (7)

comment:1 by Stan, 5 years ago

I guess one would have a hard time rewriting all the contributor's code in case he doesn't answer for re-licensing though; silence not being consent.

Thanks for the digging !

comment:2 by elexis, 5 years ago

For r7854:

Index: binaries/data/mods/public/gui/credits/texts/programming.json
===================================================================
--- binaries/data/mods/public/gui/credits/texts/programming.json	(revision 22321)
+++ binaries/data/mods/public/gui/credits/texts/programming.json	(working copy)
@@ -171,7 +171,7 @@
 			{"nick": "otero"},
 			{"nick": "nani", "name": "S. N."},
 			{"nick": "Nescio"},
-			{"name": "Nick Owens"},
+			{"nick": "DigitalSeraphim", "name": "Nick Owens"},
 			{"nick": "Palaxin", "name": "David A. Freitag"},
 			{"name": "Paul Withers"},
 			{"nick": "paulobezerr", "name": "Paulo George Gomes Bezerra"},
2010/2010-08/2010-08-06-QuakeNet-#0ad.log-01:15 <@Philip-> DigitalSeraphim: I should add you to http://trac.wildfiregames.com/browser/ps/trunk/source/contributors.txt so I was wondering if you had a name and publishable email address that could go in there
2010/2010-08/2010-08-06-QuakeNet-#0ad.log:01:17 < DigitalSeraphim> sure Nick Owens <REDACTED Privacy eMail>
2010/2010-08/2010-08-06-QuakeNet-#0ad.log-01:17 < DigitalSeraphim> thanks :^)

comment:3 by elexis, 4 years ago

Patch: Phab:D2436

Phab:D2436 handles the identified authors, the remaining TODO is to dig through the rest of old irclogs from Philip and that forum posts to identify who else is missing (hence keeping backlogged).

comment:4 by elexis, 4 years ago

Component: Core engineUI – Miscellaneous
Description: modified (diff)

comment:5 by elexis, 4 years ago

In 23181:

Add some missing historic credits, refs #5444.

Excerpt from Differential Revision https://code.wildfiregames.com/D2436
Comments By: Stan

comment:6 by elexis, 4 years ago

In 23182:

Add Balancing credits, refs #5444.

This allows merging community balancing patches without giving them false or no credit.

Differential Revision: https://code.wildfiregames.com/D2436
Comments By: Stan

comment:7 by Itms, 4 years ago

The "Community and Management" credit page is a bit lackluster.

I think it needs a section for Community Liaison (listing plumo and Sundiata, respectively past and current holder). I think it also needs a section for the Lobby Moderators (user1 is already here but not marked as lobby manager; the lobby moderators I know are not there or not listed as such).

Maybe we could expand that page further, since community is important, but for now I see those two improvements.

Note: See TracTickets for help on using tickets.