Changes between Initial Version and Version 1 of Ticket #5496, comment 3


Ignore:
Timestamp:
Jul 12, 2019, 4:38:16 PM (5 years ago)
Author:
elexis

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #5496, comment 3

    initial v1  
    11The crash happens because UnitMotion requests a long path, and PathResult sends a "MoveFailed" message, which calls StopMoving(), making the call [https://code.wildfiregames.com/source/0ad/browse/ps/trunk/source/simulation2/components/CCmpUnitMotion.cpp$735 here] return garbage since the goal computation fails.
    22
    3 D1907 also exhibits this problem. Two fixes:
     3Phab:D1907 also exhibits this problem. Two fixes:
    44- PathResult should check if there is still a move request when computing a path - this doesn't fix this particular case but it is sane.
    5 - Calls to ComputeGoal should check if it succeeded, implemented in D2063
     5- Calls to ComputeGoal should check if it succeeded, implemented in Phab:D2063