UnitMotion waypoint OOS / hash mismatch in nonvisual replay mode

[elexis]

Reproduce:

• Start a match (I tested on mainland)
• Run the replay of that match in non-visual replay mode
• Notice that the initial hashes match, but at some point there is an OOS (hash mismatch)

Experienced with r22477.

[elexis]

Sample file

[elexis]

I ran the non-visual and visual replay with -ooslog, used a tool like diff or kdiff3 to compare the differences of the two and got this:

   UnitMotion:
     pass class: "default"
     ticket: 0
     ticket type: 0
     failed path computations: 0
     pretendLongPathIsCorrect: false
     target type: 1
     target entity: 0
     target pos x: 901.4413
     target pos y: 792.15854
     target min range: 10.0778
     target max range: -1
     speed multiplier: 1
     current speed: 0
     facePointAfterMove: false
     length: 1
     waypoint x: 904.9664
     waypoint z: 781.44558
-    length: 1
-    waypoint x: 902.55536
-    waypoint z: 790.55407
+    length: 2
+    waypoint x: 907.39534
+    waypoint z: 789.72835
+    waypoint x: 911.44057
+    waypoint z: 789.25013
   Vision:
   VisualActor:
     base actor: "fauna/sheep3.xml"
     r: 1
     g: 1
     b: 1
     anim name: "idle"

which reminds me of r22470 which involved undefined data, if I'm not mistaken there was another commit prior with UB.

[elexis]

Skirmish map with simstates on the affected turn, relating to above debugging

[wraitii]

Thanks for the report, will try and fix tonight.

[wraitii]

Can you run the above replays on a clean 22478 and say if you get the same hashes?

[elexis]

replay+simstates of nani and FeldFeld who were OOS, nani was host, both windows users. r22482

[wraitii]

In 22483:

Fix undefined behaviour introduced in rP22473

rP22473 introduces undefined behaviour: for vertices that are part of non-AA squares, the value of "quadOutward" is undefined. This fixes that by again setting it to QUADRANT_ALL by default, as it was pre rP22473. This led to OOS.

Reviewed By: elexis

Fixes #5508

Differential Revision: ​https://code.wildfiregames.com/D2082