#5522 closed defect (fixed)
Grid.h memory leak
Reported by: | Minohaka | Owned by: | wraitii |
---|---|---|---|
Priority: | Release Blocker | Milestone: | Alpha 24 |
Component: | Simulation | Keywords: | regression |
Cc: | Patch: |
Description
Assertion failed: "0 && (L"FYI: WARN_IF_FALSE reports that a function failed. Feel free to ignore or suppress this warning.")"
Location: wdbg_sym.cpp:91 (InitDbghelp)
Attachments (4)
Change History (12)
by , 5 years ago
Attachment: | crashlog.txt added |
---|
by , 5 years ago
Attachment: | crashlog.dmp added |
---|
by , 5 years ago
Attachment: | commands.txt added |
---|
comment:1 by , 5 years ago
comment:2 by , 5 years ago
I'm pretty sure there's some memory leak somewhere. I often play the same scenario in the A23 version and I never get OOM problems. Furthermore I was playing the same scenario 4*200 on linux the game reached 22GB of ram at one point. I don't think that's normal regardless of the 4K monitor and many units on the map or maybe I'm wrong. Sorry I don't have more specific insight on the matter
comment:3 by , 5 years ago
Milestone: | Backlog → Alpha 24 |
---|---|
Priority: | Should Have → Release Blocker |
comment:4 by , 5 years ago
Component: | Core engine → Simulation |
---|---|
Summary: | Assertion failed: "0 && (L"FYI: WARN_IF_FALSE reports that a function failed. Feel free to ignore or suppress this warning.")" → Some memory leak |
Please always post the revision you're running the replay with, it wasn't obvious that it is alpha 24 and that you reported a huge memory leak regression (at least assuming that the report is valid).
The replay is done with 3 AIs, so one could easily blame that.
When doing the a24 testgame in #5529 without AIs, my computer froze because of out-of-memory.
I did a testgame with 50 cavalry units, no AIs and letting the cavalry run in circles (without increasing much map vision), and the game increased by 100mb ram usage every 45s or so.
So it seems like there is some unitmotion/pathfinder leak?
by , 5 years ago
Attachment: | commands.2.txt added |
---|
r22537 replay with 50 cav units running in circles, memory use > 1.3GB
comment:5 by , 5 years ago
See https://code.wildfiregames.com/rP22511#inline-3747
Indeed a release blocker, indeed in the pathfinder (specifically the long pathfinder).
See D2121 for a possible fix.
comment:7 by , 5 years ago
Summary: | Some memory leak → Grid.h memory leak |
---|
comment:8 by , 5 years ago
Keywords: | regression added |
---|
I guess that's following the discussion in http://irclogs.wildfiregames.com/2019-07/2019-07-19-QuakeNet-%230ad-dev.log
It speaks of
But that is probably it failing to use your memory.
You had also posted some GL errors.
One needs to be able to reproduce the issue, so one needs to know which steps you performed that led to this crash, and ideally find a way to perform the same steps to reliably get the same result; then one can inspect and possibly fix it.
We mentioned to test that using replaymode. If it's 4v4 * 150 on a normal mapsize, that certainly ought not to crash or fail due to OOM.