Changes between Initial Version and Version 13 of Ticket #5524


Ignore:
Timestamp:
May 2, 2020, 6:59:07 PM (4 years ago)
Author:
Krinkle
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #5524

    • Property Owner set to Krinkle
    • Property Patch → phab:D2103, phab:D2070
    • Property Keywords contributor-experience added

  • Ticket #5524 – Description

    initial v13  
    1414
    1515The style rules can be easily and safely auto-fixed by `eslint --fix`, which performs non-semantic changes only. The quality violations are best addressed in smaller changes focussing on an individual area only with understanding of local context.
     16
     17--
     18
     19contributor-experience: Having ESLint passing generally suggests (although not per se) that most of our style guides are encoded in the lint configuration, this means new contributors can automatically write code correctly and have fewer hurdles. Either because their IDE auto-matically corrects or guides them as they go, or because they find out automatically from Jenkins with wording (ESLint warnings) that are familiar to them if they have JS experience outside 0AD, or can generally learn much about on the Internet given there's lots of docs out there about JS and ESLint.
     20
     21It also drains less reviewer time, and has the potential to improve code quality overall.