this.order is undefined in INDIVIDUAL.PATROL.MovementUpdate
In this r22537 replay,
after sending a Patrol order to these units, I got this error message:
TypeError: this.order is undefined
UnitAI.prototype.UnitFsmSpec.INDIVIDUAL.PATROL.MovementUpdate@simulation/components/UnitAI.js:1594:5
FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:265:12
UnitAI.prototype.OnMotionUpdate@simulation/components/UnitAI.js:3866:2
ERROR: Script message handler OnMotionUpdate failed
ERROR: JavaScript error: simulation/components/UnitAI.js line 1594
TypeError: this.order is undefined
UnitAI.prototype.UnitFsmSpec.INDIVIDUAL.PATROL.MovementUpdate@simulation/components/UnitAI.js:1594:5
FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:265:12
UnitAI.prototype.OnMotionUpdate@simulation/components/UnitAI.js:3866:2
ERROR: Script message handler OnMotionUpdate failed
Introduced by Phab:rP22526 L1589 of UnitAI.js . I call FinishOrder() but don't return and thus this.order is undefined below it.
I'll check the diff for other similar mistakes since this is not so obvious a bug form reading the code and fix it.
Thanks for reporting.