Opened 5 years ago

Last modified 4 years ago

#5538 new defect

Improve hwdetect config override behavior

Reported by: historic_bruno Owned by:
Priority: Should Have Milestone: Backlog
Component: Core engine Keywords:
Cc: Patch:

Description

Currently, hwdetect is used to override default.cfg settings for various graphics cards and drivers that we've found to have issues. It should override default.cfg, but not user-applied settings from local.cfg/user.cfg. It should also use the standard JSI_ConfigDB interface. There are several TODOs to that effect:

HWDetect.cpp 

// The Set* functions will override the default behaviour, unless the user
// has explicitly set a config variable to override that.
// (TODO: This is an ugly abuse of the config system)

hwdetect.js 

// TODO: add some mechanism for setting config values
// (overriding default.cfg, but overridden by local.cfg)

See ​Phab:D2123 for related discussion.

Change History (2)

comment:2 by wraitii, 4 years ago

In 23747:

Refactor HWDetect and rendering options setup.

Remove duplication when setting graphic options by reading the configDB directly.
Properly protect the ModIO config keys.

Approved By: linkmauve

Refs #5538

Differential Revision: ​https://code.wildfiregames.com/D1931

Note: See TracTickets for help on using tickets.