Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#5565 closed enhancement (fixed)

Record Replays in Nonvisual Mode

Reported by: Brian Broll Owned by: elexis
Priority: Nice to Have Milestone: Alpha 24
Component: Core engine Keywords:
Cc: Brian Broll Patch: Phab:D2197

Description (last modified by Brian Broll)

Adding support for an RL interface enables a nonvisual game to play out differently based on the actions of the agent using the RPC interface. This makes recording replays while in nonvisual mode valuable as checkpoints can be watched during training/evaluation.

I have already added this to the work that I have done mentioned in but thought it would be nice to split these into separate contributions.

Change History (7)

comment:1 by Brian Broll, 4 years ago

Description: modified (diff)

comment:2 by Brian Broll, 4 years ago

I have created a revision on phabricator ( Let me know if there is anything else I can do!

comment:3 by Brian Broll, 4 years ago

Cc: Brian Broll added
Milestone: BacklogWork In Progress
Patch: Phab:D2197

comment:4 by Stan, 4 years ago

Splitting them is a good thought :)

comment:5 by elexis, 4 years ago

Milestone: Work In ProgressAlpha 24

comment:6 by elexis, 4 years ago

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 22991:

Save replay metadata for non-visual games too, refs #4577, #5548, fixes #5565.

Remove gui/common/ hack by going through the GUIInterface and fragile EndGame() hardcoding by saving if and only if a ReplayLogger exists following rP18613, refs #4020.
Refs D2211, D2213.

Differential Revision:
Based on patch by: irishninja
Tested on: clang 8.0.1, Jenkins

comment:7 by elexis, 4 years ago

In 22992:

Fix previous, don't save replay metadata if a multiplayer gamesetup page was opened and closed, refs rP22991 / D2197, refs #5565.

Note: See TracTickets for help on using tickets.