Opened 5 years ago

Closed 5 years ago

#5572 closed defect (fixed)

Wonder population upgrade broken

Reported by: elexis Owned by:
Priority: Must Have Milestone: Alpha 24
Component: Simulation Keywords: regression
Cc: Patch: ​Phab:D2236

Description (last modified by elexis)

As reported by minoahaka on IRC tonight, the Wonder population bonus is not applied anymore as of r22789. Reproduce is building the wonder and having houses. I've attached a replay without "gift from the gods" cheat. Perhaps it was r22767.

Attachments (1)

commands.txt​ (33.3 KB ) - added by elexis 5 years ago.

Download all attachments as: .zip

Change History (5)

by elexis, 5 years ago

Attachment: commands.txt​ added

comment:1 by elexis, 5 years ago

Description: modified (diff)
Milestone: Backlog → Alpha 24

comment:2 by elexis, 5 years ago

Keywords: regression added
Patch: → Phab:D2236
Priority: Release Blocker → Must Have

comment:3 by wraitii, 5 years ago

In 22813:

Fix modifiers affecting player entity following ModifiersManager component in rP22767

Modifiers affecting the player entity itself were not applying correctly.
The reason was that the cache was not correctly reset.
Adds a regression test.

Reported By: Minohaka

Tested By: Minohaka

Refs #5572 (probably fixed but kept open for verifiation).

Differential Revision: ​https://code.wildfiregames.com/D2236

comment:4 by wraitii, 5 years ago

Resolution: → fixed
Status: new → closed

Erf, actually meant the above for #5569, this is _definitely_ fixed, I got confused.

Thanks for reporting.

Note: See TracTickets for help on using tickets.