Opened 5 years ago

Closed 5 years ago

#5580 closed defect (fixed)

Coastal wave foam glitch/bug. Not following the shore.

Reported by: nani Owned by: wraitii
Priority: Should Have Milestone: Alpha 24
Component: Core engine Keywords: regression
Cc: Patch: Phab:D2249

Description


Attachments (2)

screenshot0023.jpg (775.8 KB ) - added by nani 5 years ago.
screenshot0024.jpg (688.9 KB ) - added by nani 5 years ago.

Download all attachments as: .zip

Change History (6)

by nani, 5 years ago

Attachment: screenshot0023.jpg added

by nani, 5 years ago

Attachment: screenshot0024.jpg added

comment:1 by nani, 5 years ago

Summary: coastal wave foam glitch/bug. Not following the shore.Coastal wave foam glitch/bug. Not following the shore.

comment:2 by elexis, 5 years ago

Keywords: regression added
Priority: Nice to HaveShould Have

Bug is fixed by reverting Phab:rP22006, see also screenshots over there.

(11:39:54 PM) nani: if (m_DistanceHeightmap[z*m_MapSize + x] > 0.5f && m_DistanceHeightmap[z*m_MapSize + x] < 1.5f)

comment:3 by wraitii, 5 years ago

Owner: set to wraitii
Patch: Phab:D2249

Thanks for reporting, the code was in fact buggy but the bugginess made it sorta work sometimes, so it wasn't that obvious.

comment:4 by wraitii, 5 years ago

Resolution: fixed
Status: newclosed

In 22862:

Fix algorithmic error in rP22006 (waves computation speedup), and delete unused code.

rP22006 introduced a much faster (for a little precision cost) algorithm to compute distance to shore. However a condition was incorrectly inverted, which made the algorithm return less-than-sensible results in many situations.

Further, there was some unused code left behind which is now removed.

Fixes #5580

Reported by: nani (shore bug), elexis (unused code)

Differential Revision: https://code.wildfiregames.com/D2249

Note: See TracTickets for help on using tickets.