Opened 5 years ago

Closed 4 years ago

#5626 closed defect (fixed)

UnitMotionFlying IsMoveRequested error

Reported by: Stan Owned by: Silier
Priority: Should Have Milestone: Alpha 24
Component: Simulation Keywords: regression
Cc: wraitii Patch: ​Phab:D2450

Description

Steps to reproduce:

  • Open Atlas.
  • Open a map, for ex Temperate Roadway (2)
  • Place a plane assigned to player 1
  • Run the simulation, the plane will try to attack enemies, and warnings will pop up. 
    Error calling component script function IsMoveRequested

Expected behavior:

  • Warnings should not appear

Change History (5)

comment:1 by elexis, 5 years ago

Component: Core engine → Simulation
Keywords: regression added
Milestone: Backlog → Alpha 24

Perhaps r22568.

(Searched 2019 logs for unitmotionflying and only found the infinite loop issue described in ​Phab:rP22313)

Also if you already have a replay, it doesnt cost much but may help to upload it. (Edit: You used atlas, so you don't have a replay, nvm)

Last edited 5 years ago by elexis (previous) (diff)

comment:2 by elexis, 5 years ago

Summary: Error while playing with the plane → UnitMotionFlying IsMoveRequested error

comment:3 by Silier, 4 years ago

actually it was r22526

Last edited 4 years ago by Silier (previous) (diff)

comment:4 by Silier, 4 years ago

Patch: → Phab:D2450

comment:5 by Silier, 4 years ago

Owner: set to Silier
Resolution: → fixed
Status: new → closed

In 23208:

Fix UnitmotionFlying and implement CMessageMotionUpdate::FromJSVal
In rP22526 have been changed message from MotionChanged to MotionUpdate and CMessageMotionUpdate::FromJSVal was not implemented to reflect changes in message structure.
As a result UnitMotionFlying tries to send MotionChanged message which not only was renamed, but sending it from js is not supported anymore.
Also reported at this thread: ​https://wildfiregames.com/forum/index.php?/topic/27294-cheats-error/

Differential Revision: ​https://code.wildfiregames.com/D2450
Tested by: @gameboy
Tested on: Jenkins/vs2015, Jenkins/gcc6
Fixes: #5626

Note: See TracTickets for help on using tickets.