GetRealPath doesn't

[Philip Taylor]

IVFS::GetRealPath claims to "retrieve the real (POSIX) pathname underlying a VFS file", but it seems to work incorrectly with mods. In particular, it always returns a path like .../data/mods/public/... (or always internal if that mod is loaded), even when the VFS file comes from a different mod.

CXeromyces::GetXMBPath tries to get the mod name from this, which doesn't work since it always returns public (or always internal).

Getting the mod name seems like useful functionality - by separating caches per mod, we can avoid one mod maliciously polluting the cache with a file with the same size/timestamp as another mod's but with different content (which would probably cause OOS errors after the first mod is disabled).

I don't know what GetRealPath should return if the file is in an archive. (It probably doesn't matter here, since archives ought to already contain cached files and we won't need to dynamically generate them.)

[Jan Wassenberg]

(In [8082]) fix VFS real path retrieval for files mounted from multiple directories (e.g. mods) closes #564 GetRealPath was too simplistic and just asked the directory *most recently mounted* into the file's VFS directory for its path. the correct solution is to ask the file's loader for its path. the archiver IFileLoader new returns the archive's pathname as the real path. also simplified VfsFile's interface.

[(none)]

Milestone Unclassified deleted