format.h is bugged

[Silier]

fmt::internal::CharTraits<char>::convert': cannot access private member declared

that basically means one cannot use wstring and pass it to LOGWARNING or similar calls, where conversion is needed.

Issue have been fixed, but we have outdated version: ​https://github.com/fmtlib/fmt/issues/117 File itself is available here: ​https://github.com/fmtlib/fmt/blob/master/include/fmt/format.h

One cannot simply download and replace the file, because there have been done modifications to our version of file, so they need to be done in new version of file too.

Code to reproduce:

LOGWARNING("Passed wrong value %ls", L"wstring");

[adrian]

@Angen could you say how to reproduce this bug?

I put LOGWARNING(L"warning") and LOGWARNING(std::wstring("warning")) in some file and I received completely different compiler errors like followings:

error: no matching function for call to ‘sprintf(const wchar_t [36])’

error: no matching function for call to ‘std::__cxx11::basic_string<wchar_t>::basic_string(const char [11])’

[Silier]

Replying to adrian:

@Angen could you say how to reproduce this bug?

Sorry it took me so long, I have updated ticket with example.

[adrian]

@Angen I updated fmt, preserving previous changes. Everything is compiling, tests are passing. What is the next step? This will be my first commit to the 0ad codebase :)

[Silier]

Thank you for working on this :) You would need to create an account here ​https://code.wildfiregames.com/ and upload there your diff.

For more detailed steps take a look here: ​https://trac.wildfiregames.com/wiki/SubmittingPatches ​https://trac.wildfiregames.com/wiki/Phabricator

also do not forget to add yourself to the credits: binaries/data/mods/public/gui/credits/texts/programming.json

[adrian]

Added diff for a review ​Phab:D2613

[Itms]

Thanks for the patch! This is related to tickets #3190 and #4148.

[Itms]

In 23562:

Update cppformat from v0.11.0 to v1.1.0, fixes #5646, refs #3190.
Use the opportunity to rename the lib from cppformat to fmt, refs #4148.

Patch By: adrian
Rebased By: s0600204
Differential Revision: ​https://code.wildfiregames.com/D2613