INDIVIDUAL.COMBAT.CHASING but idling

[elexis]

In this replay with r23292, there are two skirmisher cavalry units of mine that received queued orders to hunt deer.

But instead of going there, they stood around in the idle animation in INDIVIDUAL.COMBAT.CHASING state.

When they received a non-queued order, the state was reset.

Replay at ​Phab:F1188774

[elexis]

One of them has entityID 24688.

[Freagarach]

Entity 24688 is due to #5610 (please note they were in the "CHASING"-state, not "APPROACHING"). (Happens around turn 900.) The reason why its two friends didn't experience the same behaviour is because they received an order to go from chasing to attacking in the same turn the deer died. In attacking there *is* a check for dead targets, whilst in chasing there is not.

[elexis]

The other skirmisher cavalry was 24737, it was also in the CHASING state, so I reasonably assume it's the same issue.

Thanks for the investigation!

[Silier]

In 23566:

React to target death properly when chasing

Differential Revision: ​https://code.wildfiregames.com/D2517
Reviewed by: Freagarach
Comments by: elexis, Stan
Fixes: #5610 #5656

Introduce likelyFailure check in the movementupdate for chasing state missing since rP22526.
Use new order and substate for Chasing to get into the wanted range and avoid that way issue with running - walking tracking or animation variants.

Fixing issue when attacker would not react to the death of the target while chasing it in stances where results for abandoning chasing are always false and also do not rely on timer ending chasing for the rest of stances.