Opened 4 years ago

Closed 2 years ago

#5680 closed defect (fixed)

Some animals have too slow walking speed compared to animation

Reported by: Silier Owned by: pszemsza
Priority: Must Have Milestone: Alpha 26
Component: Simulation Keywords: simple
Cc: pszemsza Patch: Phab:D3891

Description (last modified by pszemsza)

Reported originally in #5338. Too slow walking speed makes animations used when moving look odd and unnatural. This can be fixed in two ways:
adjust animation if walking speed is desired as it is now
change walking speed to the point walking and running looks good and animal is not too fast

List of reported animals with this problem (there are probably more)

camel
cow
sanga cattle
zebu

Change History (11)

comment:1 by Silier, 3 years ago

Keywords: simple added
Milestone: Alpha 24Backlog

comment:2 by pszemsza, 3 years ago

Description: modified (diff)

I created a map filled with camels (and virtually all other land animals) to recreate the problem and I noticed a couple of more with this exact problem (cow, sanga cattle, and zebu - I added them to the list above). I think for these animals slowing the animation down would look more realistic than increasing the walking speed, but I'm not sure how to do that.

comment:3 by Stan, 3 years ago

You need to edit the art/actors/* files. There you can change the animation speed.

comment:4 by pszemsza, 3 years ago

Cc: pszemsza added
Milestone: BacklogWork In Progress
Owner: set to pszemsza
Patch: Phab:D3891
Status: newassigned

Thanks stanislas69! I was looking at these files and I've seen the corresponding tag for animals like deer or tiger, but they were missing for the animals mentioned here. Took me a while to find out that they were inherited from art\variants\quadraped.

comment:5 by pszemsza, 3 years ago

BTW, the patch also decreases the walking and animation speed for deer and gazelle. As I was looking at different animals it seemed to me that (while they are fast in real life) they move unnaturally fast for "walking" (as in casual grazing etc.). Looking at #5338 it seems that this was done by design; I'm fine with reverting the change if you think it worked fine.

comment:6 by Ceres, 3 years ago

I look into the zipped file:

\binaries\data\mods\public\public.zip\art\actors\fauna

and find only these 2 files related to "camel":

camel.xml

camel.xml.cached.xmb

So far, am I on the right track? I assume that the first file is the relevant one to start from, but where would I continue about the speed of movement etc.?

The first file contains:

<group> <variant file="quadraped/base_camel_fauna.xml"/> <variant file="quadraped/base_camel_run.xml" /> <variant file="quadraped/base_camel_death.xml" /> </group>

Are these 3 "base" files the relevant ones? Where do I find them? I searched for "quadraped" and found the aforementioned files there:

\binaries\data\mods\public\public\art\variants\quadraped

E.g.:

<?xml version="1.0" encoding="UTF-8"?>
<variant name="Base" frequency="1">
<animations>
<animation file="quadraped/camel_idle_01.dae" name="Idle" id="idle1" speed="80"/>
<animation file="quadraped/camel_idle_02.dae" name="Idle" id="idle2" speed="80"/>
<animation file="quadraped/camel_idle_03.dae" name="Idle" id="idle3" speed="80"/>
<animation file="quadraped/camel_idle_04.dae" name="Idle" id="idle4" speed="80"/>
<animation file="quadraped/camel_attack_melee_01.dae" name="Attack_Melee" id="attack1" speed="100"/>
<animation file="quadraped/camel_attack_melee_02.dae" name="Attack_Melee" id="attack2" speed="100"/>
<animation file="quadraped/camel_death.dae" name="Death" speed="120"/>
<animation file="quadraped/camel_walk.dae" name="Walk" speed="35"/>
<animation file="quadraped/camel_trot.dae" name="Run" speed="5"/>
</animations>
</variant>

Is this the right place to tweak the camel's speed?

Sorry about these many noob questions of mine. I really appreciate you developers' and contributors' patience with me. While I am willing to learn, I might be a bit slow.

Last edited 3 years ago by Ceres (previous) (diff)

in reply to:  3 comment:7 by Ceres, 3 years ago

Replying to stanislas69:

You need to edit the art/actors/* files. There you can change the animation speed.

But the animation speed is not in these files, or is it?

I found these files and assume that they are relevant - at least they contain speed values - see e.g.:

/binaries/data/mods/public/art/variants/quadraped/base_camel_fauna.xml /binaries/data/mods/public/simulation/templates/gaia/fauna_camel.xml

However, I have no idea which of the files needs to be adjusted, or both? Is one for the animation speed and the other for the speed of movement?

Please forgive me my mane questions across different places, e.g. also there: https://code.wildfiregames.com/D3891 https://wildfiregames.com/forum/topic/45569-trained-animals/?do=findComment&comment=438583

Maybe it is not apporpriate that I ask similar questions in these different places. I simply do not (yet) understand where they should belong to. Thanks for your patience with me. ;-)

comment:8 by Silier, 3 years ago

Keywords: simple removed
severity: simple

comment:9 by Silier, 3 years ago

Keywords: simple added

comment:10 by Langbart, 3 years ago

Milestone: Work In ProgressAlpha 26

comment:11 by Stan, 2 years ago

Resolution: fixed
Status: assignedclosed

In 26622:

Adjusted walking speed and animation speed for a number of animals:

  • camel, cow, sanga cattle, zebu: decreased animation speed
  • deer and gazelle: decreased animation speed and walking speed.

Fixes #5680
Differential Revision: https://code.wildfiregames.com/D3891

Note: See TracTickets for help on using tickets.