Opened 4 years ago

Closed 4 years ago

#5695 closed defect (fixed)

Middle mouse button get stuck

Reported by: Stan Owned by: Imarok
Priority: Should Have Milestone: Alpha 24
Component: Core engine Keywords: regression
Cc: Imarok Patch:

Description

When playing a game today with Freagarach, I noticed the middle mouse button get stuck quite often for some reason, might be r23505

Steps to reproduce:

  • Press the middle mouse button.
  • Drag until your cursor is over the minimap or any GUI element.
  • Release the middle mouse button.
  • Notice it's still enabled.

Change History (1)

comment:1 by Imarok, 4 years ago

Owner: set to Imarok
Resolution: → fixed
Status: new → closed

In 23589:

Revert rP23505 / r23505

Summary: Having a mouse event and a hotkey for the same hardware key turned out to be bad. If the mouse is above a gui element that handles the middle mouse event and the middle mouse is released, this event will be consumed by the gui handler of this gui element. Therefore the hotkey handler does not know that the key was released. If we change that behaviour typing in input fields would trigger hotkeys. So this seems unsolvable without adding special handling for the middle mouse case, which would be ugly.

Fixes: #5695

Differential Revision: ​https://code.wildfiregames.com/D2700

Note: See TracTickets for help on using tickets.