Opened 4 years ago

Closed 3 years ago

#5710 closed defect (fixed)

Trunk failing on macOS (NVTT build failed)

Reported by: Krinkle Owned by:
Priority: Release Blocker Milestone: Alpha 24
Component: Build & Packages Keywords:
Cc: Patch: Phab:D2563

Description

On latest master / trunk (r23563),

running ./build-osx-libs.sh -j3 --force-rebuild

Eventually fails on NVTT:

[ 76%] Building CXX object src/nvtt/CMakeFiles/nvtt.dir/BlockCompressor.cpp.o
In file included from /Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/BlockCompressor.cpp:27:
In file included from /Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/TaskDispatcher.h:14:
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/dispatch/dispatch.h:36:45: error: expected value in expression
#if !defined(HAVE_UNISTD_H) || HAVE_UNISTD_H
                                            ^
[ 77%] Building CXX object src/nvtt/CMakeFiles/nvtt.dir/CompressorDX9.cpp.o
1 error generated.
make[3]: *** [src/nvtt/CMakeFiles/nvtt.dir/BlockCompressor.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from /Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/CompressorDX9.cpp:35:
In file included from /Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/squish/colourset.h:30:
In file included from /Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/squish/maths.h:35:
/Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/squish/config.h:46:5: warning: macro expansion producing 'defined' has undefined behavior
      [-Wexpansion-to-defined]
#if SQUISH_USE_ALTIVEC && SQUISH_USE_SSE
    ^
/Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/squish/config.h:31:29: note: expanded from macro 'SQUISH_USE_ALTIVEC'
#       define SQUISH_USE_ALTIVEC defined(__VEC__)
                                  ^
/Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/squish/config.h:49:5: warning: macro expansion producing 'defined' has undefined behavior
      [-Wexpansion-to-defined]
#if SQUISH_USE_ALTIVEC || SQUISH_USE_SSE
    ^
/Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/squish/config.h:31:29: note: expanded from macro 'SQUISH_USE_ALTIVEC'
#       define SQUISH_USE_ALTIVEC defined(__VEC__)
                                  ^
In file included from /Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/CompressorDX9.cpp:35:
In file included from /Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/squish/colourset.h:31:
/Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/squish/simd.h:37:5: warning: macro expansion producing 'defined' has undefined behavior
      [-Wexpansion-to-defined]
#if SQUISH_USE_ALTIVEC
    ^
/Users/krinkle/Development/0ad-git/libraries/source/nvtt/src/src/nvtt/squish/config.h:31:29: note: expanded from macro 'SQUISH_USE_ALTIVEC'
#       define SQUISH_USE_ALTIVEC defined(__VEC__)
                                  ^
3 warnings generated.
make[2]: *** [src/nvtt/CMakeFiles/nvtt.dir/all] Error 2
make[1]: *** [src/nvtt/CMakeFiles/nvtt.dir/rule] Error 2
make: *** [nvtt] Error 2
ERROR: NVTT build failed

Full output from building all libs: https://gist.github.com/Krinkle/d1ae569d51b03e13d39861326c6019ae

Change History (5)

comment:1 by Krinkle, 4 years ago

Recent changes to NVTT:

I recall this having broken earlier this year, but I thought that was fixed. I remember confirming that. Did it break again?

comment:2 by Itms, 4 years ago

Patch: Phab:D2563

Hey sorry about that, yes it is fixed by Phab:D2563, which I haven't committed yet (I am mostly away, up until June, sorry about this). If I can commit it this weekend I will.

comment:3 by Silier, 4 years ago

Priority: Must HaveRelease Blocker

comment:4 by Krinkle, 4 years ago

Keywords: macos added

comment:5 by Stan, 3 years ago

Keywords: macos removed
Resolution: fixed
Status: newclosed

In r24245:

Fix recent macOS builds. Fix aarch64 build for NVTT. Fix warning about GLVND when building on Linux (Patch by @Stan) Native EOLs.

Patch by: @Itms

Differential Revision: ​https://code.wildfiregames.com/D2563

Note: See TracTickets for help on using tickets.