Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#5712 closed defect (fixed)

Capture points not initialised properly.

Reported by: Freagarach Owned by: Silier
Priority: Release Blocker Milestone: Alpha 24
Component: Simulation Keywords: simple regression
Cc: Patch: Phab:D2706

Description

I noticed something weird with walls. If you build one piece, then upgrade to the next phase, its CP go from 1200 to 1320 for Athens. But new wall pieces are not affected. For Britons the CP change from 1200 to 960.

I traced the issue to the capture points not being initialised properly. this.maxCp is used without value modifications on init, but when a OnValueModification message is received modifications are applied.

Change History (6)

comment:1 by elexis, 4 years ago

Keywords: regression added
Milestone: BacklogAlpha 24

Nice find. Reproducible with r23475, not reproducible with a23b.

comment:2 by Freagarach, 4 years ago

Apparently I found it before: #5588. Introduced in r22767.

comment:3 by Silier, 4 years ago

Priority: Must HaveRelease Blocker

we cant release product that breaks something what was working

comment:4 by Silier, 4 years ago

Milestone: Alpha 24Work In Progress
Owner: set to Silier
Patch: Phab:D2706

comment:5 by Silier, 4 years ago

Resolution: fixed
Status: newclosed

In 23633:

Fix Capture points not initialised properly.

Differential Revision: https://code.wildfiregames.com/D2706
Fixes: #5712

Correctly check for timer when regeneration rate is affected by modifications but not capture points.
Move frequently affected values with modifications called by timer to prototype.
Recompute all cached values affected by modifications when ownership is transfered.
Recompute cached values before initialising capture points first time fixing rP22767.

comment:6 by Silier, 4 years ago

Milestone: Work In ProgressAlpha 24
Note: See TracTickets for help on using tickets.