Opened 4 years ago

Closed 3 years ago

#5785 closed defect (fixed)

[svn]When re-hosting, map preview shows incorrect biome

Reported by: Andy Alt Owned by: Silier
Priority: Must Have Milestone: Alpha 24
Component: UI – Game setup Keywords:
Cc: Patch: ​Phab:D3041

Description (last modified by Andy Alt)

Hosted a game, set map to Mainland. Changed biome to Autumn, map preview correct at that point. Played game. Ended game. Rehosted with same settings, so the biome was still set to Autumn, but preview showed Temperate biome. Reproducible.

On the svn version, from GitHub, at commit a176d92

I hosted through the svn lobby. The incorrect map preview also appeared to the player connected to me.

Change History (4)

comment:1 by Andy Alt, 4 years ago

Description: modified (diff)

comment:3 by Silier, 4 years ago

Owner: set to Silier
Patch: → Phab:D3041
Status: new → assigned

comment:4 by Silier, 3 years ago

Resolution: → fixed
Status: assigned → closed

In 24139:

Always update preview in biome and landscape

Introduced in rP23392.
Landscape and Biome previews are not updated correctly when reopeneing gamesetup.
To solve that, remove lastBiome and lastLandscape and always try to update preview if preview file exists and does not match with current one.

Differential revision: D3041
Reviewed by: @Freagarach
Fixes: #5785

Note: See TracTickets for help on using tickets.